[or-cvs] Note a bug that causes servers to sometimes never send the ...

[arma at seul.org]

Update of /home2/or/cvsroot/tor/src/or
In directory moria:/home/arma/work/onion/cvs/tor/src/or

Modified Files:
	circuitbuild.c 
Log Message:
Note a bug that causes servers to sometimes never send the pending
create cell. Nick, is this a bug? If so, is my fix right?


Index: circuitbuild.c
===================================================================
RCS file: /home2/or/cvsroot/tor/src/or/circuitbuild.c,v
retrieving revision 1.235
retrieving revision 1.236
diff -u -p -d -r1.235 -r1.236
--- circuitbuild.c	4 Jun 2006 22:42:12 -0000	1.235
+++ circuitbuild.c	5 Jun 2006 07:27:48 -0000	1.236
@@ -449,6 +449,14 @@ circuit_n_conn_done(connection_t *or_con
         }
         tor_free(circ->onionskin);
         circuit_set_state(circ, CIRCUIT_STATE_OPEN);
+        /* XXX: Since circuit_set_state removes circ from the
+         * circuits_pending_or_conns, we will skip over whatever
+         * the next entry is when we proceed with the SMARTLIST_FOREACH.
+         * Thus if there's ever more than one entry, we will miss some.
+         *
+         * Is this true? If so, is the fix to decrement circ_sl_idx
+         * here too? -RD
+         */
       }
     }
   });