[or-cvs] r6926: More asserts in dns.c (tor/trunk/src/or)

nickm at seul.org nickm at seul.org
Thu Jul 27 18:35:57 UTC 2006


Author: nickm
Date: 2006-07-27 14:35:56 -0400 (Thu, 27 Jul 2006)
New Revision: 6926

Modified:
   tor/trunk/src/or/dns.c
Log:
More asserts in dns.c 

Modified: tor/trunk/src/or/dns.c
===================================================================
--- tor/trunk/src/or/dns.c	2006-07-27 18:35:25 UTC (rev 6925)
+++ tor/trunk/src/or/dns.c	2006-07-27 18:35:56 UTC (rev 6926)
@@ -224,10 +224,11 @@
 static void
 purge_expired_resolves(uint32_t now)
 {
-  cached_resolve_t *resolve;
+  cached_resolve_t *resolve, *removed;
   pending_connection_t *pend;
   edge_connection_t *pendconn;
 
+  assert_cache_ok();
   /* this is fast because the linked list
    * oldest_cached_resolve is ordered by when they came in.
    */
@@ -264,10 +265,12 @@
     if (!oldest_cached_resolve) /* if there are no more, */
       newest_cached_resolve = NULL; /* then make sure the list's tail knows
                                      * that too */
-    HT_REMOVE(cache_map, &cache_root, resolve);
+    removed = HT_REMOVE(cache_map, &cache_root, resolve);
+    tor_assert(removed == resolve);
     resolve->magic = 0xF0BBF0BB;
     tor_free(resolve);
   }
+  assert_cache_ok();
 }
 
 /** Send a response to the RESOVLE request of a connection. answer_type must
@@ -595,7 +598,8 @@
   }
 
   /* remove resolve from the map */
-  HT_REMOVE(cache_map, &cache_root, resolve);
+  tmp = HT_REMOVE(cache_map, &cache_root, resolve);
+  tor_assert(tmp == resolve);
   resolve->magic = 0xAAAAAAAA;
   tor_free(resolve);
 }



More information about the tor-commits mailing list