[or-cvs] put one of the XXX"s back in

arma at seul.org arma at seul.org
Tue Apr 25 07:06:50 UTC 2006


Update of /home2/or/cvsroot/tor/src/or
In directory moria:/home/arma/work/onion/cvs/tor/src/or

Modified Files:
	circuitbuild.c 
Log Message:
put one of the XXX's back in


Index: circuitbuild.c
===================================================================
RCS file: /home2/or/cvsroot/tor/src/or/circuitbuild.c,v
retrieving revision 1.231
retrieving revision 1.232
diff -u -p -d -r1.231 -r1.232
--- circuitbuild.c	18 Apr 2006 03:07:24 -0000	1.231
+++ circuitbuild.c	25 Apr 2006 07:06:48 -0000	1.232
@@ -1421,6 +1421,10 @@ count_acceptable_routers(smartlist_t *ro
     if (r->is_valid == 0) {
 //      log_debug(LD_CIRC,"Nope, the directory says %d is not valid.",i);
       goto next_i_loop;
+      /* XXX This clause makes us count incorrectly: if AllowInvalidRouters
+       * allows this node in some places, then we're getting an inaccurate
+       * count. For now, be conservative and don't count it. But later we
+       * should try to be smarter. */
     }
     num++;
 //    log_debug(LD_CIRC,"I like %d. num_acceptable_routers now %d.",i, num);



More information about the tor-commits mailing list