[or-cvs] by convention, addr is a uint32_t and address is a string.

arma at seul.org arma at seul.org
Fri Sep 30 21:30:06 UTC 2005


Update of /home2/or/cvsroot/tor/src/or
In directory moria:/home/arma/work/onion/cvs/tor/src/or

Modified Files:
	connection.c 
Log Message:
by convention, addr is a uint32_t and address is a string.
that's why we hadn't caught that leak.


Index: connection.c
===================================================================
RCS file: /home2/or/cvsroot/tor/src/or/connection.c,v
retrieving revision 1.402
retrieving revision 1.403
diff -u -d -r1.402 -r1.403
--- connection.c	30 Sep 2005 21:28:00 -0000	1.402
+++ connection.c	30 Sep 2005 21:30:04 -0000	1.403
@@ -858,11 +858,11 @@
     line = NULL;
     SMARTLIST_FOREACH(launch, config_line_t *, wanted,
       {
-        char *addr=NULL;
+        char *address=NULL;
         uint16_t port;
-        if (! parse_addr_port(wanted->value, &addr, NULL, &port)) {
-          int addr_matches = !strcasecmp(addr, conn->address);
-          tor_free(addr);
+        if (! parse_addr_port(wanted->value, &address, NULL, &port)) {
+          int addr_matches = !strcasecmp(address, conn->address);
+          tor_free(address);
           if (! port)
             port = port_option;
           if (port == conn->port && addr_matches) {



More information about the tor-commits mailing list