[or-cvs] Note that there is incorrect behavior in directory.c code. ...

Nick Mathewson nickm at seul.org
Fri Sep 30 01:38:12 UTC 2005


Update of /home/or/cvsroot/tor/src/or
In directory moria:/tmp/cvs-serv12903/src/or

Modified Files:
	directory.c 
Log Message:
Note that there is incorrect behavior in directory.c code.  Arma, please check this too.

Index: directory.c
===================================================================
RCS file: /home/or/cvsroot/tor/src/or/directory.c,v
retrieving revision 1.295
retrieving revision 1.296
diff -u -d -r1.295 -r1.296
--- directory.c	30 Sep 2005 01:09:52 -0000	1.295
+++ directory.c	30 Sep 2005 01:38:09 -0000	1.296
@@ -1011,7 +1011,13 @@
     if (which) {
       /* We only call these if it's a "fp/" request, since
        * it's the only way we'll be adding new server descriptors
-       * and thus the only way we'd affect has_fetched_directory. */
+       * and thus the only way we'd affect has_fetched_directory.
+       *
+       * XXXX Not so.  We will fetch "all" routers if we have zero or one
+       * networkstatus, so we can bootstrap faster.  See
+       * update_router_descriptor_downloads(). One of these behaviors is
+       * wrong.
+       **/
 
       /* as we learn from them, we remove them from 'which' */
       router_load_routers_from_string(body, 0, which);



More information about the tor-commits mailing list