[or-cvs] remove redundant logs about unreachable servers

arma at seul.org arma at seul.org
Sat Sep 3 04:37:32 UTC 2005


Update of /home2/or/cvsroot/tor/src/or
In directory moria:/home/arma/work/onion/cvs/tor/src/or

Modified Files:
	dirserv.c main.c or.h 
Log Message:
remove redundant logs about unreachable servers


Index: dirserv.c
===================================================================
RCS file: /home2/or/cvsroot/tor/src/or/dirserv.c,v
retrieving revision 1.205
retrieving revision 1.206
diff -u -d -r1.205 -r1.206
--- dirserv.c	3 Sep 2005 02:38:39 -0000	1.205
+++ dirserv.c	3 Sep 2005 04:37:30 -0000	1.206
@@ -554,25 +554,6 @@
   return 0;
 }
 
-/** Log complaints about each server that is connected to us and has
- * been found unreachable for the past several testing periods.
- */
-void
-dirserv_log_unreachable_servers(time_t now)
-{
-  smartlist_t *descriptor_list = get_descriptor_list();
-  if (!descriptor_list)
-    return;
-
-  SMARTLIST_FOREACH(descriptor_list, routerinfo_t *, ri,
-  {
-    if (dirserv_thinks_router_is_blatantly_unreachable(ri, now))
-      log_fn(LOG_NOTICE,
-             "Router %s (%s:%d) is connected to us but not reachable by us.",
-             ri->nickname, ri->address, ri->or_port);
-  });
-}
-
 /* Given a (possibly empty) list of config_line_t, each line of which contains
  * a list of comma-separated version numbers surrounded by optional space,
  * allocate and return a new string containing the version numbers, in order,

Index: main.c
===================================================================
RCS file: /home2/or/cvsroot/tor/src/or/main.c,v
retrieving revision 1.544
retrieving revision 1.545
diff -u -d -r1.544 -r1.545
--- main.c	26 Aug 2005 20:59:04 -0000	1.544
+++ main.c	3 Sep 2005 04:37:30 -0000	1.545
@@ -692,7 +692,6 @@
     routerlist_remove_old_routers(ROUTER_MAX_AGE);
 
     if (authdir_mode(options)) {
-      dirserv_log_unreachable_servers(now);
       if (!we_are_hibernating()) { /* try to determine reachability */
         router_retry_connections(1);
       }

Index: or.h
===================================================================
RCS file: /home2/or/cvsroot/tor/src/or/or.h,v
retrieving revision 1.664
retrieving revision 1.665
diff -u -d -r1.664 -r1.665
--- or.h	2 Sep 2005 20:37:31 -0000	1.664
+++ or.h	3 Sep 2005 04:37:30 -0000	1.665
@@ -1677,7 +1677,6 @@
 int dirserv_thinks_router_is_blatantly_unreachable(routerinfo_t *router,
                                                    time_t now);
 int list_server_status(smartlist_t *routers, char **router_status_out);
-void dirserv_log_unreachable_servers(time_t now);
 int dirserv_dump_directory_to_string(char **dir_out,
                                      crypto_pk_env_t *private_key);
 void directory_set_dirty(void);



More information about the tor-commits mailing list