[or-cvs] answer nick"s XXX, and muck with some log domain choices

[arma at seul.org]

Update of /home2/or/cvsroot/tor/src/or
In directory moria:/home/arma/work/onion/cvs/tor/src/or

Modified Files:
	cpuworker.c directory.c 
Log Message:
answer nick's XXX, and muck with some log domain choices


Index: cpuworker.c
===================================================================
RCS file: /home2/or/cvsroot/tor/src/or/cpuworker.c,v
retrieving revision 1.92
retrieving revision 1.93
diff -u -d -r1.92 -r1.93
--- cpuworker.c	29 Oct 2005 19:13:48 -0000	1.92
+++ cpuworker.c	1 Nov 2005 06:13:12 -0000	1.93
@@ -163,13 +163,17 @@
       circ = circuit_get_by_circid_orconn(circ_id, p_conn);
 
     if (success == 0) {
-      debug(LD_OR,"decoding onionskin failed. (Old key or bad sw.) Closing.");
+      debug(LD_OR,"decoding onionskin failed. (Old key or bad software.) Closing.");
       if (circ)
         circuit_mark_for_close(circ);
       goto done_processing;
     }
     if (!circ) {
-      /*XXXX Why does this happen?*/
+      /* This happens because somebody sends us a destroy cell and the
+       * circuit goes away, while the cpuworker is working. This is also
+       * why our tag doesn't include a pointer to the circ, because we'd
+       * never know if it's still valid.
+       */
       debug(LD_OR,"processed onion for a circ that's gone. Dropping.");
       goto done_processing;
     }
@@ -259,7 +263,7 @@
     }
 
     if (read_all(fd, question, ONIONSKIN_CHALLENGE_LEN, 1) != ONIONSKIN_CHALLENGE_LEN) {
-      info(LD_BUG,"read question failed. Exiting.");
+      err(LD_BUG,"read question failed. Exiting.");
       goto end;
     }
 

Index: directory.c
===================================================================
RCS file: /home2/or/cvsroot/tor/src/or/directory.c,v
retrieving revision 1.316
retrieving revision 1.317
diff -u -d -r1.316 -r1.317
--- directory.c	27 Oct 2005 23:16:08 -0000	1.316
+++ directory.c	1 Nov 2005 06:13:12 -0000	1.317
@@ -814,7 +814,7 @@
                               &body, &body_len, MAX_DIR_SIZE,
                               allow_partial)) {
     case -1: /* overflow */
-      warn(LD_BUG,"'fetch' response too large (server '%s:%d'). Closing.", conn->address, conn->port);
+      warn(LD_PROTOCOL,"'fetch' response too large (server '%s:%d'). Closing.", conn->address, conn->port);
       return -1;
     case 0:
       info(LD_HTTP,"'fetch' response not all here, but we're at eof. Closing.");