[or-cvs] when you type "getinfo" with no arguments, it doesn"t give ...

[arma at seul.org]

Update of /home2/or/cvsroot/tor/src/or
In directory moria:/home/arma/work/onion/cvs/tor/src/or

Modified Files:
	control.c 
Log Message:
when you type 'getinfo' with no arguments, it doesn't give you
any answer at all. this is clearly a bug.

the more interesting bug is whether things like setconf, getconf,
and so on should return 250 OK if you give them no arguments. should
we have a new "you didn't ask me anything" response code, or just
leave it as is?


Index: control.c
===================================================================
RCS file: /home2/or/cvsroot/tor/src/or/control.c,v
retrieving revision 1.148
retrieving revision 1.149
diff -u -d -r1.148 -r1.149
--- control.c	16 Nov 2005 23:54:24 -0000	1.148
+++ control.c	17 Nov 2005 21:45:38 -0000	1.149
@@ -1452,7 +1452,7 @@
     tor_assert(msg_len > 0); /* it will at least be terminated */
     send_control0_message(conn, CONTROL0_CMD_INFOVALUE,
                           msg_len, msg);
-  } else if (smartlist_len(answers)) {
+  } else {
     int i;
     for (i = 0; i < smartlist_len(answers); i += 2) {
       char *k = smartlist_get(answers, i);