[or-cvs] note a bug in our tor_socketpair implementation

[arma at seul.org]

Update of /home2/or/cvsroot/tor/src/common
In directory moria:/home/arma/work/onion/cvs/tor/src/common

Modified Files:
	compat.c 
Log Message:
note a bug in our tor_socketpair implementation
can somebody fix this or create a flyspray entry for it?


Index: compat.c
===================================================================
RCS file: /home2/or/cvsroot/tor/src/common/compat.c,v
retrieving revision 1.54
retrieving revision 1.55
diff -u -d -r1.54 -r1.55
--- compat.c	18 Jun 2005 02:23:11 -0000	1.54
+++ compat.c	26 Jun 2005 05:03:21 -0000	1.55
@@ -291,6 +291,10 @@
  * stack is down). And even if it succeeds, the socket pair will not
  * be able to read while localhost is down later (the socket pair may
  * even close, depending on OS-specific timeouts).
+ *
+ * XXX Bug: this function assumes errno is how you report errors, but
+ * that isn't the case for Windows, which is where it's most likely
+ * to be called.
  **/
 int
 tor_socketpair(int family, int type, int protocol, int fd[2])