[or-cvs] note a worrying double-free possibility in torgzip.

arma at seul.org arma at seul.org
Tue Jul 12 23:21:17 UTC 2005


Update of /home2/or/cvsroot/tor/src/common
In directory moria:/home/arma/work/onion/cvs/tor/src/common

Modified Files:
	torgzip.c 
Log Message:
note a worrying double-free possibility in torgzip.
nick?


Index: torgzip.c
===================================================================
RCS file: /home2/or/cvsroot/tor/src/common/torgzip.c,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -d -r1.18 -r1.19
--- torgzip.c	11 Jun 2005 05:31:15 -0000	1.18
+++ torgzip.c	12 Jul 2005 23:21:15 -0000	1.19
@@ -208,7 +208,7 @@
   *out_len = stream->total_out;
   if (inflateEnd(stream)!=Z_OK) {
     log_fn(LOG_WARN, "Error freeing gzip structures");
-    goto err;
+    goto err; /* XXX this will try to inflateEnd again, right? is that bad? */
   }
   tor_free(stream);
 



More information about the tor-commits mailing list