[or-cvs] answer question about rep_hist_note_connect_failed

Nick Mathewson nickm at seul.org
Wed Oct 13 19:42:39 UTC 2004


Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/tmp/cvs-serv22122/or

Modified Files:
	connection.c 
Log Message:
answer question about rep_hist_note_connect_failed

Index: connection.c
===================================================================
RCS file: /home/or/cvsroot/src/or/connection.c,v
retrieving revision 1.254
retrieving revision 1.255
diff -u -d -r1.254 -r1.255
--- connection.c	12 Oct 2004 15:52:09 -0000	1.254
+++ connection.c	13 Oct 2004 19:42:36 -0000	1.255
@@ -195,6 +195,10 @@
         /* XXX Nick: this still isn't right, because it might be
          * dying even though we didn't initiate the connect. Can
          * you look at this more? -RD XXXX008 -NM*/
+        /* XXX We only set conn->nickname when we initiate the connection, or
+         * when the handshake is complete; so conn->nickname is a good test
+         * for "we initiated the connection", right? -NM */
+         */
         if(conn->nickname)
           rep_hist_note_connect_failed(conn->identity_digest, time(NULL));
       } else if (0) { // XXX reason == CLOSE_REASON_UNUSED_OR_CONN) {



More information about the tor-commits mailing list