[or-cvs] Remove XXXX009 comment telling us to do the last (circID-re...

Nick Mathewson nickm at seul.org
Wed Nov 10 20:19:48 UTC 2004


Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/tmp/cvs-serv19969/src/or

Modified Files:
	circuitbuild.c 
Log Message:
Remove XXXX009 comment telling us to do the last (circID-related) fix

Index: circuitbuild.c
===================================================================
RCS file: /home/or/cvsroot/src/or/circuitbuild.c,v
retrieving revision 1.54
retrieving revision 1.55
diff -u -d -r1.54 -r1.55
--- circuitbuild.c	10 Nov 2004 20:14:37 -0000	1.54
+++ circuitbuild.c	10 Nov 2004 20:19:45 -0000	1.55
@@ -350,15 +350,6 @@
   tor_assert(circ->n_conn->type == CONN_TYPE_OR);
   tor_assert(payload);
 
-  /* XXXX009 How can we keep a good upgrade path here?  We should
-   * compare keys, not nicknames...but older servers will compare nicknames.
-   * Should we check server version from the most recent directory? Hm.
-   *
-   * This is important if anybody is unverified.
-   *
-   * Solution: switch to identity-based comparison, but if we get
-   * any circuits in the wrong half of the space, switch.
-   */
   circ->n_circ_id = get_unique_circ_id_by_conn(circ->n_conn);
   if(!circ->n_circ_id) {
     log_fn(LOG_WARN,"failed to get unique circID.");



More information about the tor-commits mailing list