[or-cvs] assert_cpath_ok has always been broken

Roger Dingledine arma at seul.org
Thu May 13 07:44:24 UTC 2004


Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/home2/arma/work/onion/dev/src/or

Modified Files:
	circuitlist.c 
Log Message:
assert_cpath_ok has always been broken
re-disable it.


Index: circuitlist.c
===================================================================
RCS file: /home/or/cvsroot/src/or/circuitlist.c,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- circuitlist.c	13 May 2004 07:24:49 -0000	1.1
+++ circuitlist.c	13 May 2004 07:44:21 -0000	1.2
@@ -423,6 +423,7 @@
 {
   while(cp->prev)
     cp = cp->prev;
+  //XXX this is broken. cp is a doubly linked list.
 
   while(cp->next) {
     assert_cpath_layer_ok(cp);
@@ -478,7 +479,8 @@
     }
   }
   if (c->cpath) {
-    assert_cpath_ok(c->cpath);
+//    assert_cpath_ok(c->cpath);
+// XXX the above call causes an infinite loop.
   }
   if (c->purpose == CIRCUIT_PURPOSE_REND_ESTABLISHED) {
     if (!c->marked_for_close) {



More information about the tor-commits mailing list