[or-cvs] use "notice" loglevel for things the operator should hear

Roger Dingledine arma at seul.org
Tue Mar 30 03:15:55 UTC 2004


Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/home2/arma/work/onion/cvs/src/or

Modified Files:
	circuit.c config.c main.c 
Log Message:
use 'notice' loglevel for things the operator should hear
but that aren't warnings


Index: circuit.c
===================================================================
RCS file: /home/or/cvsroot/src/or/circuit.c,v
retrieving revision 1.158
retrieving revision 1.159
diff -u -d -r1.158 -r1.159
--- circuit.c	21 Mar 2004 06:33:57 -0000	1.158
+++ circuit.c	30 Mar 2004 03:15:53 -0000	1.159
@@ -1256,7 +1256,7 @@
   log_fn(LOG_INFO,"finished");
   if(!has_completed_circuit) {
     has_completed_circuit=1;
-    log_fn(LOG_WARN,"Tor has successfully opened a circuit. Looks like it's working.");
+    log_fn(LOG_NOTICE,"Tor has successfully opened a circuit. Looks like it's working.");
   }
   circuit_log_path(LOG_INFO,circ);
   circuit_rep_hist_note_result(circ);

Index: config.c
===================================================================
RCS file: /home/or/cvsroot/src/or/config.c,v
retrieving revision 1.101
retrieving revision 1.102
diff -u -d -r1.101 -r1.102
--- config.c	30 Mar 2004 00:06:59 -0000	1.101
+++ config.c	30 Mar 2004 03:15:53 -0000	1.102
@@ -419,7 +419,7 @@
 static void init_options(or_options_t *options) {
 /* give reasonable values for each option. Defaults to zero. */
   memset(options,0,sizeof(or_options_t));
-  options->LogLevel = tor_strdup("warn");
+  options->LogLevel = tor_strdup("notice");
   options->ExitNodes = tor_strdup("");
   options->EntryNodes = tor_strdup("");
   options->ExcludeNodes = tor_strdup("");
@@ -501,8 +501,7 @@
   cf = config_open(fname);
   if(!cf) {
     if(using_default_torrc == 1) {
-      log(LOG_WARN, "Configuration file '%s' not found, using defaults (this is fine).",fname);
-      /* XXX change this WARN to INFO once we start using this feature */
+      log(LOG_NOTICE, "Configuration file '%s' not present, using reasonable defaults.",fname);
       if(config_assign_default(options) < 0)
         return -1;
     } else {
@@ -549,12 +548,14 @@
       options->loglevel = LOG_ERR;
     else if(!strcmp(options->LogLevel,"warn"))
       options->loglevel = LOG_WARN;
+    else if(!strcmp(options->LogLevel,"notice"))
+      options->loglevel = LOG_NOTICE;
     else if(!strcmp(options->LogLevel,"info"))
       options->loglevel = LOG_INFO;
     else if(!strcmp(options->LogLevel,"debug"))
       options->loglevel = LOG_DEBUG;
     else {
-      log(LOG_WARN,"LogLevel must be one of err|warn|info|debug.");
+      log(LOG_WARN,"LogLevel must be one of err|warn|notice|info|debug.");
       result = -1;
     }
   }

Index: main.c
===================================================================
RCS file: /home/or/cvsroot/src/or/main.c,v
retrieving revision 1.210
retrieving revision 1.211
diff -u -d -r1.210 -r1.211
--- main.c	29 Mar 2004 19:28:16 -0000	1.210
+++ main.c	30 Mar 2004 03:15:53 -0000	1.211
@@ -472,7 +472,7 @@
       add_stream_log(options.loglevel, "<stderr>", stderr);
       log_fn(LOG_WARN, "Cannot write to LogFile '%s': %s.", options.LogFile, strerror(errno));
     }
-    log_fn(LOG_WARN, "Successfully opened LogFile '%s', redirecting output.",
+    log_fn(LOG_NOTICE, "Successfully opened LogFile '%s', redirecting output.",
            options.LogFile);
   }
   if(options.DebugLogFile) {
@@ -499,7 +499,7 @@
 static int do_hup(void) {
   char keydir[512];
 
-  log_fn(LOG_WARN,"Received sighup. Reloading config.");
+  log_fn(LOG_NOTICE,"Received sighup. Reloading config.");
   has_completed_circuit=0;
   /* first, reload config variables, in case they've changed */
   /* no need to provide argc/v, they've been cached inside init_from_config */
@@ -730,7 +730,7 @@
 
   /* give it somewhere to log to initially */
   add_stream_log(LOG_INFO, "<stdout>", stdout);
-  log_fn(LOG_WARN,"Tor v%s. This is experimental software. Do not use it if you need anonymity.",VERSION);
+  log_fn(LOG_NOTICE,"Tor v%s. This is experimental software. Do not use it if you need anonymity.",VERSION);
 
   if (network_init()<0) {
     log_fn(LOG_ERR,"Error initializing network; exiting.");



More information about the tor-commits mailing list