[or-cvs] writing html in C strings sucks

Roger Dingledine arma at seul.org
Thu Feb 26 22:10:57 UTC 2004


Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/home2/arma/work/onion/cvs/src/or

Modified Files:
	buffers.c 
Log Message:
writing html in C strings sucks


Index: buffers.c
===================================================================
RCS file: /home/or/cvsroot/src/or/buffers.c,v
retrieving revision 1.61
retrieving revision 1.62
diff -u -d -r1.61 -r1.62
--- buffers.c	26 Feb 2004 22:02:22 -0000	1.61
+++ buffers.c	26 Feb 2004 22:10:55 -0000	1.62
@@ -544,7 +544,7 @@
     case 'C': /* connect */
       strcpy(req->reply,
 "HTTP/1.0 501 Tor is not an HTTP Proxy\r\n"
-"Content-Type: text/html; charset=iso-8859-1\r\n"
+"Content-Type: text/html; charset=iso-8859-1\r\n\r\n"
 "<html>\n"
 "<head>\n"
 "<title>Tor is not an HTTP Proxy</title>\n"
@@ -553,7 +553,7 @@
 "It appears you have configured your web browser to use Tor as an HTTP Proxy.\n"
 "This is not correct: Tor provides a SOCKS proxy. Please configure your\n"
 "client accordingly.\n"
-"See <a href=\"http://freehaven.net/tor/cvs/INSTALL\">http://freehaven.net/tor/cvs/INSTALL</a for more information.\n"
+"See <a href=\"http://freehaven.net/tor/cvs/INSTALL\">http://freehaven.net/tor/cvs/INSTALL</a> for more information.\n"
 "<!-- Plus this comment, to make the body response more than 512 bytes, so IE will be willing to display it. Comment comment comment comment comment comment comment comment comment comment comment comment.-->\n"
 "</body>\n"
 "</html>\n"
@@ -561,7 +561,7 @@
       req->replylen = strlen(req->reply)+1;
       /* fall through */
     default: /* version is not socks4 or socks5 */
-      log_fn(LOG_WARN,"Socks version %d not recognized. (Tor is not an httpd proxy.)",
+      log_fn(LOG_WARN,"Socks version %d not recognized. (Tor is not an http proxy.)",
              *(buf->mem));
       return -1;
   }



More information about the tor-commits mailing list