[or-cvs] note a bug in our dns error handling. we should fix this so...

Roger Dingledine arma at seul.org
Thu Aug 5 19:33:56 UTC 2004


Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/home2/arma/work/onion/cvs/src/or

Modified Files:
	dns.c 
Log Message:
note a bug in our dns error handling. we should fix this sometime.


Index: dns.c
===================================================================
RCS file: /home/or/cvsroot/src/or/dns.c,v
retrieving revision 1.103
retrieving revision 1.104
diff -u -d -r1.103 -r1.104
--- dns.c	22 Jul 2004 22:15:36 -0000	1.103
+++ dns.c	5 Aug 2004 19:33:54 -0000	1.104
@@ -661,6 +661,7 @@
       result = -1;
     switch (result) {
       case 1:
+/* XXX008 result can never be 1, because we set it to -1 above on error */
         log_fn(LOG_INFO,"Could not resolve dest addr %s (transient).",address);
         answer[0] = DNS_RESOLVE_FAILED_TRANSIENT;
         break;



More information about the tor-commits mailing list