[or-cvs] log a warning if you"re running an unverified server, to let

Roger Dingledine arma at seul.org
Wed Aug 4 01:17:23 UTC 2004


Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/home2/arma/work/onion/cvs/src/or

Modified Files:
	routerparse.c 
Log Message:
log a warning if you're running an unverified server, to let
you know you might want to get it verified

also, moved that whole block below the check-signature logic, so
we don't execute it if the directory is a fake.

(the recommended-versions logic is still executed before the signature
is checked; we should fix that.)


Index: routerparse.c
===================================================================
RCS file: /home/or/cvsroot/src/or/routerparse.c,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -d -r1.19 -r1.20
--- routerparse.c	22 Jul 2004 22:15:36 -0000	1.19
+++ routerparse.c	4 Aug 2004 01:17:21 -0000	1.20
@@ -390,14 +390,6 @@
   }
   tok->n_args = 0; /* Don't free the strings in good_nickname_lst yet. */
 
-  /* Determine if my routerinfo is considered verified. */
-  {
-    routerinfo_t *me = router_get_my_routerinfo();
-    if(me)
-      router_update_status_from_smartlist(me, published_on,
-                                          good_nickname_list);
-  }
-
   /* Read the router list from s, advancing s up past the end of the last
    * router. */
   str = end;
@@ -427,6 +419,21 @@
     goto err;
   }
 
+  /* Determine if my routerinfo is considered verified. */
+  {
+    static int have_warned_about_unverified_status = 0;
+    routerinfo_t *me = router_get_my_routerinfo();
+    if(me) {
+      router_update_status_from_smartlist(me, published_on,
+                                          good_nickname_list);
+      if(me->is_verified == 0 && !have_warned_about_unverified_status) {
+        log_fn(LOG_WARN,"Dirserver %s lists your server as unverified. Please consider sending your identity fingerprint to the tor-ops.", "");
+        /* XXX008 can we print the name of the dirserver above? how to get it */
+        have_warned_about_unverified_status = 1;
+      }
+    }
+  }
+
   if (*dest)
     routerlist_free(*dest);
   *dest = new_dir;



More information about the tor-commits mailing list