[or-cvs] bugfix: alice would crash if bob advertised 0 intro points

Roger Dingledine arma at seul.org
Thu Apr 8 03:18:05 UTC 2004


Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/home2/arma/work/onion/cvs/src/or

Modified Files:
	rendclient.c 
Log Message:
bugfix: alice would crash if bob advertised 0 intro points


Index: rendclient.c
===================================================================
RCS file: /home/or/cvsroot/src/or/rendclient.c,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -d -r1.28 -r1.29
--- rendclient.c	8 Apr 2004 02:24:06 -0000	1.28
+++ rendclient.c	8 Apr 2004 03:18:03 -0000	1.29
@@ -284,6 +284,10 @@
     smartlist_add(sl,entry->parsed->intro_points[i]);
 
   choice = smartlist_choose(sl);
+  if(!choice) {
+    smartlist_free(sl);
+    return NULL;
+  }
   nickname = tor_strdup(choice);
   smartlist_free(sl);
   return nickname;



More information about the tor-commits mailing list