[or-cvs] serious bug in cpuworker. need to think about redesign or h...

[Roger Dingledine]

Update of /home/or/cvsroot/src/or
In directory moria.mit.edu:/home2/arma/work/onion/cvs/src/or

Modified Files:
	cpuworker.c 
Log Message:
serious bug in cpuworker. need to think about redesign or how to handle it.


Index: cpuworker.c
===================================================================
RCS file: /home/or/cvsroot/src/or/cpuworker.c,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -d -r1.2 -r1.3
--- cpuworker.c	23 Aug 2003 10:09:25 -0000	1.2
+++ cpuworker.c	12 Sep 2003 06:18:38 -0000	1.3
@@ -55,6 +55,7 @@
 
     connection_fetch_from_buf(buf,LEN_ONION_RESPONSE,conn);
 
+    /* XXX conn->circ might already have been closed. Serious bug. Suck. */
     if(*buf == 0 || conn->circ->p_conn == NULL ||
        onionskin_process(conn->circ, buf+1, buf+1+DH_KEY_LEN) < 0) {
       log_fn(LOG_DEBUG,"decoding onion, onionskin_process, or p_conn failed. Closing.");