[tor-bugs] #34250 [Applications/Tor Browser]: Fix torbutton noscript-control race condition

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat May 30 11:52:08 UTC 2020


#34250: Fix torbutton noscript-control race condition
--------------------------------------+-----------------------------
 Reporter:  acat                      |          Owner:  acat
     Type:  defect                    |         Status:  merge_ready
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam202005R     |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+-----------------------------

Comment (by rustybird):

 Replying to [ticket:34250 acat]:
 > In that ticket, "pageshow" was added `for a slightly more graceful
 failure mode in case Torbutton somehow misses NoScript startup`.

 This was for Tor Browser 8.0.x, when Torbutton was still an extension.
 IIRC the situation I had in mind was that the user had, maybe by mistake,
 disabled and then re-enabled Torbutton. (But given that Torbutton wasn't a
 restartless extension, the only way that even makes marginal sense to me
 now is on the off change that re-enabling causes some sort of delay during
 the next startup.) Anyway, kill that cruft with fire. :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34250#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list