[tor-bugs] #34286 [Applications/GetTor]: gettor appears to be in an email loop war with a .sk address

[Tor Bug Tracker & Wiki]

#34286: gettor appears to be in an email loop war with a .sk address
---------------------------------+-----------------------------
 Reporter:  arma                 |          Owner:  cohosh
     Type:  defect               |         Status:  merge_ready
 Priority:  Medium               |      Milestone:
Component:  Applications/GetTor  |        Version:
 Severity:  Normal               |     Resolution:
 Keywords:                       |  Actual Points:
Parent ID:                       |         Points:
 Reviewer:  phw                  |        Sponsor:
---------------------------------+-----------------------------
Changes (by phw):

 * status:  needs_review => merge_ready


Comment:

 Looks good to me!

 On a slightly related note: I believe that an email's body is supposed to
 be separated by two (rather than one) newlines from its header. GetTor's
 unit tests are using only one (and mix \n with \r\n). Python's email
 module is also confused by this and thinks that the body is part of the
 `To` field:

 {{{
 In [1]: from email import message_from_string
 In [3]: m=message_from_string("From: MAILER-
 DAEMON at mx1.riseup.net\nSubject: Undelivered Mail Returned to Sender\r\nTo:
 gettor at torproject.org\n osx en\n")
 In [6]: m.items()
 Out[6]:
 [('From', 'MAILER-DAEMON at mx1.riseup.net'),
  ('Subject', 'Undelivered Mail Returned to Sender'),
  ('To', 'gettor at torproject.org\n osx en')]
 }}}

 This seems like something we should fix.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34286#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online