[tor-bugs] #33258 [Metrics/Onionperf]: Add CSV file export of graphed data

[Tor Bug Tracker & Wiki]

#33258: Add CSV file export of graphed data
---------------------------------------+--------------------------------
 Reporter:  karsten                    |          Owner:  karsten
     Type:  enhancement                |         Status:  closed
 Priority:  Medium                     |      Milestone:
Component:  Metrics/Onionperf          |        Version:
 Severity:  Normal                     |     Resolution:  implemented
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  1.9
Parent ID:  #33327                     |         Points:  3
 Reviewer:  acute                      |        Sponsor:  Sponsor59-must
---------------------------------------+--------------------------------
Changes (by karsten):

 * status:  merge_ready => closed
 * resolution:   => implemented
 * actualpoints:  1.5 => 1.9


Comment:

 Thanks a lot for this comprehensive review! This was not a tiny change,
 and it's good to have at least two eye pairs look over these changes as
 they're going to impact future changes to visualizations.

 I squashed my two commits, rebased them, and pushed them to master.

 Regarding your comments and suggestions, I think we should do the
 following:

  - It's true that some numbers are hard to read from the graphs. These
 graphs use the default template, as far as I remember. Maybe let's use
 these graphs for a while to see if we like the style. If we find ourselves
 in similar situations like you did when reading those graphs, we should
 switch to another style. It shouldn't be necessary to read the data file
 in order to understand the graph.

  - Let's add the two new libraries as part of #30586 which still needs
 discussion. I'll add a comment there.

  - We're indeed not using a style guide yet. anarcat suggested `pyflakes3`
 and `black` as two possible tools, but I'm happy to use something else
 like `yapf` or `pylint`. I'll bring this up at the next team meeting to
 have a short discussion.

  - I did not get the warnings that you got, because I'm using the pandas
 version from buster, not bullseye. But if there's a way to make both
 versions happy, let's do it. I'll open another ticket for this.

 Adding another 0.4 actual points and closing. Thanks again!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33258#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online