[tor-bugs] #33932 [Applications/Tor Browser]: Improve steps for creating gradle dependencies lists for projects

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed May 20 20:21:02 UTC 2020


#33932: Improve steps for creating gradle dependencies lists for projects
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-maint,                  |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202004       |
Parent ID:                                       |         Points:
 Reviewer:  ahf                                  |        Sponsor:
                                                 |  Sponsor58-must
-------------------------------------------------+-------------------------

Comment (by gk):

 I've an interesting issue over in #33556: when building with
 `bug_33556_v3` (commit `990368bdd87da1f4d8ccdb51ed8e911938bb6c5e`) I am
 doing the usual dance when generating the log with all the gradle deps
 downloaded (including not applying the mavenLocal() patch) and the build
 succeeds. So far so good.

 Now, if I generate the gradle depedencies with the script up for review
 and re-run the build in offline mode the build breaks, complaining
 `protobuf-javalite-3.11.4.jar` can not be found. And indeed only the .pom
 file is available. Re-checking the build without the mavenLocal() patch
 shows that Gradle is only having the .pom file in its cache as expected
 from the log. Now, the question is why the build is not failing in that
 case, too.

 Another interesting observation: if I don't build the `assembleGeckoBeta`
 target but just `assemble` the build succeeds in offline mode, too. I
 wonder where the `protobuf-javalite-3.11.4.jar` is coming from there,
 though...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33932#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list