[tor-bugs] #33973 [Applications/Tor Browser]: Create fat .aar for geckoview

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue May 19 09:33:48 UTC 2020


#33973: Create fat .aar for geckoview
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  gk
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm,                 |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005       |
Parent ID:  #33184                               |         Points:
 Reviewer:  sysrqb, ahf                          |        Sponsor:
                                                 |  Sponsor58-must
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  merge_ready => needs_review


Comment:

 Replying to [comment:31 ahf]:
 > The proposed changes seems to work. I have been able to build it
 reproducible on two different machines and learned about a hw issue on a
 third machine. It sounds like I got the same results as GeKo, which is
 good. I have not tried to build with _v8, but only with _v7, but it seems
 like _v8 is fixing the one issue I had with 'container-image'.
 >
 > The perl/bash and yaml all seems good to me.

 Thanks! I realized we should probably not just copy the .aar file over but
 the .pom one as well so the dependencies are visible, too. I pushed a
 fixup commit to `bug_33973_v8` (https://gitweb.torproject.org/user/gk/tor-
 browser-
 build.git/commit/?h=bug_33973_v8&id=7133b4d9b32008b1c5063681960888fdab1fe498)
 for review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33973#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list