[tor-bugs] #34249 [Core Tor/Tor]: Make sure the C and Rust protovers can't get out of sync

[Tor Bug Tracker & Wiki]

#34249: Make sure the C and Rust protovers can't get out of sync
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.4.4.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  044-should
Actual Points:                |  Parent ID:
       Points:  1             |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 There is a recurring bug, where we modify the C protover, but forget the
 Rust protover. (See #34248, #33285, #29631 for similar issues.)

 We could fix the underlying issue by fetching the string from a common
 location, using C's `#include` or Rust's `include_str!()`.

 Then we could test that C and Rust are the same by putting a copy of the
 protover string in the unit tests, and making sure that it matches the
 currently supported protocol versions.

 This fix and test will be important for proposal 318, because it will
 modify both protocol version implementations:
 https://github.com/torproject/torspec/blob/master/proposals/318-limit-
 protovers.md

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34249>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online