[tor-bugs] #33871 [Core Tor/sbws]: Scale exactly as torflow does?

[Tor Bug Tracker & Wiki]

#33871: Scale exactly as torflow does?
-------------------------------------------------+-------------------------
 Reporter:  juga                                 |          Owner:  juga
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  sbws:
                                                 |  1.1.x-final
Component:  Core Tor/sbws                        |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  sbws-majority-blocker, sbws-roadmap  |  Actual Points:
Parent ID:  #33775                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mikeperry):

 Oh I missed that sbws was including avg_bandwidth in the min().. That
 definitely should not be there. Average will always be below observed, and
 we want observed or burst because burst can be limited by config by
 operators who don't want traffic, giving them at least one (admittedly
 sloppy) knob to try to reduce traffic.

 I just dug a bit deeper into the 0 bw issue, and I found that we actually
 set it to at leasty 1, to simplify computation. This is done in the
 TorCtl.Router class:
 https://gitweb.torproject.org/pytorctl.git/tree/TorCtl.py#n379

 So we should probably do something that in sbws too (either hack to 1 or
 riddle with special cases everywhere), so we can still measure 0-bw
 relays.

 FYI: There is a related hack for Unmeasured=1 relays here:
 https://trac.torproject.org/projects/tor/ticket/6131

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33871#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online