[tor-bugs] #33788 [Core Tor/Tor]: Check the return value of tor_inet_ntop() and tor_inet_ntoa()

[Tor Bug Tracker & Wiki]

#33788: Check the return value of tor_inet_ntop() and tor_inet_ntoa()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review, 044-should, security-  |  Actual Points:
  low, 035-backport, 041-backport,               |
  042-backport, 043-backport, outreachy-ipv6,    |
  ipv6                                           |
Parent ID:  #33768                               |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor55-must
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:
     044-should, security-low, 035-backport, 041-backport, 042-backport,
     043-backport, outreachy-ipv6, ipv6
     =>
     extra-review, 044-should, security-low, 035-backport, 041-backport,
     042-backport, 043-backport, outreachy-ipv6, ipv6
 * reviewer:  teor =>
 * status:  needs_review => needs_revision


Comment:

 Sorry it's taken a while for me to do this review, things have been a bit
 chaotic recently.

 I think this code looks good, but it's also a bit complicated. And I'm not
 sure if we have test coverage for all these changes.

 There are also some conflicts with master.

 So I'd like someone else to review, once you've resolved those conflicts.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33788#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online