[tor-bugs] #33561 [Applications/Tor Browser]: Upgrade openssl to use Android NDK 21

[Tor Bug Tracker & Wiki]

#33561: Upgrade openssl to use Android NDK 21
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  gk
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm,                 |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005       |
Parent ID:  #33184                               |         Points:
 Reviewer:  sysrqb                               |        Sponsor:
                                                 |  Sponsor58-must
-------------------------------------------------+-------------------------

Comment (by gk):

 Similar to comment:12:ticket:33760 specifying `clang` as our compiler is
 not correct anymore with NDK 20. The fix for that is included on
 `bug_33561_v3` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33561_v3&id=696b8717e0d9d33b8a5503f3c770513b8c045cc4).

 There might still be more as `tor` is choking now but I am not sure yet
 this is an `openssl` project related bug. From `tor`'s `config.log`:
 {{{
 configure:9857: armv7a-linux-androideabi16-clang -o conftest -g -O2
 -I/var/tmp/dist/openssl/openssl/include
 -L/var/tmp/dist/openssl/openssl/lib  conftest.c -llog  -lssl -lcrypto
 >&5
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(armcap.o):armcap.c:function
 OPENSSL_cpuid_setup: error: undefined reference to 'sigfillset'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(armcap.o):armcap.c:function
 OPENSSL_cpuid_setup: error: undefined reference to 'sigdelset'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(armcap.o):armcap.c:function
 OPENSSL_cpuid_setup: error: undefined reference to 'sigdelset'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(armcap.o):armcap.c:function
 OPENSSL_cpuid_setup: error: undefined reference to 'sigdelset'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(armcap.o):armcap.c:function
 OPENSSL_cpuid_setup: error: undefined reference to 'sigdelset'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(cryptlib.o):cryptlib.c:function
 OPENSSL_showfatal: error: undefined reference to 'stderr'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(eng_openssl.o):eng_openssl.c:function
 openssl_load_privkey: error: undefined reference to 'stderr'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(eng_openssl.o):eng_openssl.c:function
 test_rc4_init_key: error: undefined reference to 'stderr'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 open_console: error: undefined reference to 'tcgetattr'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 open_console: error: undefined reference to 'stdin'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 open_console: error: undefined reference to 'stderr'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 close_console: error: undefined reference to 'stdin'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 read_string_inner: error: undefined reference to 'signal'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 read_string_inner: error: undefined reference to 'tcsetattr'
 /var/tmp/dist/openssl/openssl/lib/libcrypto.a(ui_openssl.o):ui_openssl.c:function
 read_string_inner: error: undefined reference to 'tcsetattr'
 clang: error: linker command failed with exit code 1 (use -v to see
 invocation)
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33561#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online