[tor-bugs] #34031 [Metrics/Onionperf]: Figure out warning about unknown error type when exporting .tpf file

[Tor Bug Tracker & Wiki]

#34031: Figure out warning about unknown error type when exporting .tpf file
---------------------------------------+--------------------------------
 Reporter:  karsten                    |          Owner:  acute
     Type:  defect                     |         Status:  needs_review
 Priority:  Medium                     |      Milestone:
Component:  Metrics/Onionperf          |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:  0.2
Parent ID:                             |         Points:  2
 Reviewer:  karsten                    |        Sponsor:  Sponsor59-must
---------------------------------------+--------------------------------

Comment (by acute):

 Replying to [comment:14 karsten]:

 >  - Maybe we should avoid keeping a map/dictionary with known failure
 types in metrics-lib and simply put together the error code in the format
 we want, which would be `TOR/END/INTERNAL` in this case. I'll add a new
 ticket for that. Should be an easy change.
 This is a solid approach - especially since we don't know if the latest
 Tgen reuses the same error codes. I'd also be interested in knowing how
 many total combinations are possible.
 >
 > Regarding the additional cases, I strongly believe that these are the
 result of OnionPerf's approach to match TGen transfers to streams and
 circuits, which is somewhat broken. The approach there is to match them by
 source port, but that fails as soon as the same source port is being used
 more than once per day. In metrics-lib I'm doing a somewhat more complex
 approach that also looks at start/end times of transfers and streams. That
 avoids these cases, so I'd say that there's nothing else to do here,
 assuming that we do #34141.
 I suspected this was the case, and it makes sense. In the past I tried
 matching transfer times as well as source port directly in Onionperf
 analysis, but encountered issues with log parsing and opened #30362.

 > If you agree, I'll leave a comment on #34141 that we need to fix this
 ticket, if we don't do that one. And I'll open a new ticket to tweak
 metrics-lib's code for including yet unknown error codes in Torperf
 results. And then I'll close this ticket. Makes sense?
 Yes, makes sense! Thank you for the quick review!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34031#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online