[tor-bugs] #12802 [Circumvention/BridgeDB]: BridgeDB needs Nagios checks for the Email Distributor

[Tor Bug Tracker & Wiki]

#12802: BridgeDB needs Nagios checks for the Email Distributor
-------------------------------------------------+-------------------------
 Reporter:  isis                                 |          Owner:  phw
     Type:  enhancement                          |         Status:
                                                 |  needs_information
 Priority:  High                                 |      Milestone:
Component:  Circumvention/BridgeDB               |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  bridgedb-email, nagios, anti-        |  Actual Points:
  censorship-roadmap-2020                        |
Parent ID:  #30152                               |         Points:  5
 Reviewer:  cohosh                               |        Sponsor:
                                                 |  Sponsor30-must
-------------------------------------------------+-------------------------
Changes (by cohosh):

 * status:  needs_review => needs_information


Comment:

 The script looks good to me. Some thoughts:
 - It's not super urgent in this case, but putting the email password in an
 environment variable would allow us to not have it in the bash history
 - 60 seconds seems a bit fast for email. How about making this 5-10
 minutes? I'm thinking in terms of reducing false positives plus being
 realistic about our response time to the alert.
 - Is there a reason we're logging in twice (once at
 [https://github.com/NullHypothesis/bridgedb/compare/develop...enhancement/12802
 #diff-d0583351ac71e6c7bfc1e74d665de991R56 L56] and once at
 [https://github.com/NullHypothesis/bridgedb/compare/develop...enhancement/12802
 #diff-d0583351ac71e6c7bfc1e74d665de991R128 L128])?

 Other than that, it looks good but I'll put it in needs_information

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12802#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online