[tor-bugs] #29367 [Metrics/Onionperf]: Port OnionPerf to Python 3

[Tor Bug Tracker & Wiki]

#29367: Port OnionPerf to Python 3
---------------------------------------+------------------------------
 Reporter:  irl                        |          Owner:  karsten
     Type:  defect                     |         Status:  needs_review
 Priority:  Medium                     |      Milestone:
Component:  Metrics/Onionperf          |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  metrics-team-roadmap-2020  |  Actual Points:
Parent ID:  #33318                     |         Points:  2
 Reviewer:  phw                        |        Sponsor:  Sponsor59
---------------------------------------+------------------------------
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Thanks for the review and patches!

 Regarding the second patch that turns dict keys and values into lists, I
 saw those changes, too, and did not make them on purpose. The reason is
 that we only need to iterate over these keys or values and don't need them
 as a list for further processing. But of course it doesn't do harm to
 convert them into lists, except for trivially lower performance. I think
 it's fine to just apply your patch.

 While trying out my branch (before your patches and afterwards), I found
 another problem in the analysis mode: When OnionPerf opens the Tor control
 log files containing `\r\n` as newline, it converts these newlines to just
 `\n`. But that makes Stem sad which refuses to parse the contained events.
 I wrote a patch that enables OnionPerf to open Tor control log files with
 `\r\n` as newline and that leaves them unchanged before it passes lines to
 Stem. My test instance that ran over night successfully produced an
 analysis file with TGen and Tor control log parts.

 This patch is in
 [https://gitweb.torproject.org/user/karsten/onionperf.git/commit/?h=task-29367-2&id=f863ee46e82a7acdf670752664eb4df93de0a247
 commit f863ee4 in my task-29367-2 branch] which is based on your branch.
 Can you take another look at that commit? If it looks good, I'll merge
 everything to master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29367#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online