[tor-bugs] #33812 [Core Tor/Tor]: Add unit tests for bandwidth statistics functions

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu May 7 13:00:34 UTC 2020


#33812: Add unit tests for bandwidth statistics functions
-------------------------------------------+-------------------------------
 Reporter:  MrSquanchee                    |          Owner:  MrSquanchee
     Type:  task                           |         Status:  needs_review
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  unspecified
Component:  Core Tor/Tor                   |        Version:
 Severity:  Minor                          |     Resolution:
 Keywords:  prop313, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33617                         |         Points:  2
 Reviewer:  ahf                            |        Sponsor:  Sponsor55-can
-------------------------------------------+-------------------------------

Comment (by MrSquanchee):

 In my latest commit I removed inlining from add_obs as it caused
 referencing problems
 in the functions calling it.

 Also I don't think inlining the said function would be a good idea.
 Only small functions should be ideal for inlining though.

 Thanks.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33812#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list