[tor-bugs] #33626 [Applications/Tor Browser]: Add TBB project for GeckoView

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed May 6 12:16:41 UTC 2020


#33626: Add TBB project for GeckoView
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  gk
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tbb-rbm,                 |  Actual Points:
  TorBrowserTeam202005R, GeorgKoppen202005       |
Parent ID:  #33184                               |         Points:
 Reviewer:  sysrqb                               |        Sponsor:
                                                 |  Sponsor58-must
-------------------------------------------------+-------------------------

Comment (by boklm):

 Replying to [comment:10 gk]:
 > `bug_33626_v6` (https://gitweb.torproject.org/user/gk/tor-browser-
 build.git/commit/?h=bug_33626_v6&id=288efe34fbcdbc8ea69184585646440c89f5b2d1)
 contains a patch for review.
 >
 > Ideally I'd like to have the `get-moz-build-date` either in the
 `commons` project and then refer to that from the `firefox` and
 `geckoview` config file or, less ideally, just have a symlink in
 `geckoview` pointing to the script in `firefox`. I got neither of that to
 work. Maybe boklm has an idea about how to do that.

 What happens when you do a symlink `projects/geckoview/get-moz-build-date
 -> projects/firefox/get-moz-build-date`?

 The `common` directory cannot be used for input_files (unless we change
 rbm to also look into this directory). However it can be used with
 `INCLUDE` directives in templates. So if you put `get-moz-build-date` in
 `projects/common`, you can remove it from `input_files`, and have
 something like this at the top of the `build` files:
 {{{
 cat > $rootdir/get-moz-build-date << EOF
 [% INCLUDE get-moz-build-date %]
 EOF
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33626#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list