[tor-bugs] #34078 [Core Tor/Tor]: Fix compilation warnings with clang 10.0.0

[Tor Bug Tracker & Wiki]

#34078: Fix compilation warnings with clang 10.0.0
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by nickm):

 I'm not sure whether we should clean all of the switch-statement fall-
 through warnings or not.  There are a whole bunch of them.  (See
 attachment.)

 There is just one convert-to-bool warnings though:
 {{{
 src/core/or/connection_edge.c:1662:40: error: converting the enum constant
 to a boolean [-Werror,-Wint-in-bool-context]
       (*type_out == (ONION_V2_HOSTNAME || ONION_V3_HOSTNAME) ? "onion " :
 ""),
 }}}
 That looks like a real bug.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34078#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online