[tor-bugs] #33677 [Core Tor/Chutney]: Stop waiting a set time for onion service descriptors

[Tor Bug Tracker & Wiki]

#33677: Stop waiting a set time for onion service descriptors
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  enhancement                          |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Core Tor/Chutney                     |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6, easy  |  Actual Points:
Parent ID:  #33609                               |         Points:  0.5
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor55-can
-------------------------------------------------+-------------------------

Old description:

> When we make chutney check for onion service descriptors, we can stop
> waiting a set time for onion service descriptors to download.
>
> First, set HS_WAIT_FOR_UNCHECKED_DIR_INFO to 0:
> https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L953
>
> Then check that `make test-network-all` still passes on:
> * Tor master,
> * Tor maint-0.3.5
>
> Then check that chutney's CI still passes.
>
> If all those tests pass, we can remove all the code that uses
> HS_WAIT_FOR_UNCHECKED_DIR_INFO:
> * remove HS_WAIT_FOR_UNCHECKED_DIR_INFO
> * remove getUncheckedDirInfoWaitTime()
> * remove all the variables, code, and comments that depend on
> getUncheckedDirInfoWaitTime()
>   *
> https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2226
>   *
> https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2266

New description:

 After we make chutney check for onion service descriptors In #33609, we
 can stop waiting a set time for onion service descriptors to download.

 First, set HS_WAIT_FOR_UNCHECKED_DIR_INFO to 0:
 https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L953

 Then check that `make test-network-all` still passes on:
 * Tor master,
 * Tor maint-0.3.5

 Then check that chutney's CI still passes.

 If all those tests pass, we can remove all the code that uses
 HS_WAIT_FOR_UNCHECKED_DIR_INFO:
 * remove HS_WAIT_FOR_UNCHECKED_DIR_INFO
 * remove getUncheckedDirInfoWaitTime()
 * remove all the variables, code, and comments that depend on
 getUncheckedDirInfoWaitTime()
   *
 https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2226
   *
 https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L2266

--

Comment (by teor):

 Clarify dependency on #33609.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33677#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online