[tor-bugs] #33737 [Applications/Tor Browser]: Fix aboutDialog.js error for Firefox nightlies

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Mar 26 17:01:01 UTC 2020


#33737: Fix aboutDialog.js error for Firefox nightlies
------------------------------------------+--------------------------------
     Reporter:  acat                      |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:
                                          |  TorBrowserTeam202003
Actual Points:                            |  Parent ID:  #33533
       Points:                            |   Reviewer:
      Sponsor:  Sponsor58-can             |
------------------------------------------+--------------------------------
 When opening the about dialog, there's a `TypeError: can't access property
 "hidden", document.getElementById(...) is null ... aboutDialog.js:56:14`
 error which also prevents checking for updates (`gAppUpdater` is not
 initialized). It's looking for an element with id `communityDesc`, which
 was removed in patch

 {{{
     Bug 10760: Integrate TorButton to TorBrowser core

     Bug 26321: New Circuit and New Identity menu items
 }}}

 This path is only hit with Firefox versions that match `/a\d+$/`, so we
 see this now in #33533 because of `mozilla-central`.

 Maybe a fixup for the patch hiding `communityDesc` instead of removing
 would be enough for this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33737>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list