[tor-bugs] #33650 [Core Tor/Tor]: Verify that intro2 cell extensions actually work

[Tor Bug Tracker & Wiki]

#33650: Verify that intro2 cell extensions actually work
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:
                                                 |  mikeperry
     Type:  task                                 |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-dos tor-dos-2020 anonymous-      |  Actual Points:
  credentials research                           |
Parent ID:  #33703                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by asn):

 OK I finished an experiment on the descriptor "hi-mom" test. I went to the
 `encrypted` section (which is confusingly the inner layer of the
 descriptor which only authorized clients should have access to) and added
 the following line:
 {{{
 +  smartlist_add_asprintf(lines, "hi-mom lets-defend\n");
 }}}
 [https://github.com/torproject/tor/blob/6b0a40c81eddc1ab79ad71947f85a92206947c81/src/feature/hs/hs_descriptor.c#L768
 right below] the `"single-onion-service"` line and above the intro points.

 I then started a chutney network with that patch, and ensured that clients
 can connect to the HS, and that the string is present in the client-
 received descriptor:
 {{{
 create2-formats 2
 intro-auth-required ed25519
 single-onion-service
 hi-mom lets-defend
 introduction-point AgIUQ0NDQ0NDQ0NDQ0NDQ0NDQ0NDQ0MABgECAwQjKQ==
 onion-key ntor AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=
 ...
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33650#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online