[tor-bugs] #33679 [Core Tor/Tor]: Make sure every address function that takes for_listening supports IPv6

[Tor Bug Tracker & Wiki]

#33679: Make sure every address function that takes for_listening supports IPv6
-------------------------------------------+-------------------------------
 Reporter:  teor                           |          Owner:  MrSquanchee
     Type:  task                           |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.4.4.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  prop312, ipv6, outreachy-ipv6  |  Actual Points:
Parent ID:  #33049                         |         Points:  0.5
 Reviewer:                                 |        Sponsor:
                                           |  Sponsor55-must
-------------------------------------------+-------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:2 MrSquanchee]:
 > > Make sure every address function that takes for_listening supports
 IPv6
 >
 > I see only one such function.

 There are at least 5 such functions.
 Of the ones I checked, 3 only support IPv4, and 1 already supports IPv6
 for_listening.
 Please double-check by searching address.c for for_listening.

 > You can see my PR here https://github.com/torproject/tor/pull/1831

 Thanks!

 Please update the function comment so it describes what the function does
 now.

 And please add tests for the new code you just added.

 It would also be great to simplify the IPv4 case the same way you
 simplified the IPv6 case.
 (If for_listening is true, any IPv4 address is acceptable.)

 And merge the IPv4 and IPv6 cases, if you can find a simple way to do it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33679#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online