[tor-bugs] #33672 [Applications/Tor Browser]: Force include https-everywhere in incremental mar update

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Mar 20 16:11:49 UTC 2020


#33672: Force include https-everywhere in incremental mar update
--------------------------------------+------------------------------
 Reporter:  sysrqb                    |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam202003R     |  Actual Points:  .2
Parent ID:                            |         Points:
 Reviewer:  brade, mcs                |        Sponsor:
--------------------------------------+------------------------------

Comment (by sysrqb):

 That's disappointing. I looked at staged extensions, instead of
 distribution addons, but I believe you are correct.

 [https://gitweb.torproject.org/tor-
 browser.git/tree/toolkit/mozapps/extensions/internal/XPIInstall.jsm?h=tor-
 browser-68.6.0esr-9.5-1#n3768 XPIInstall.jsm::installDistributionAddon]

 {{{
     let state = location.get(id);

     if (state) {
       try {
         let existingAddon = await loadManifestFromFile(state.file,
 location);

         if (Services.vc.compare(addon.version, existingAddon.version) <=
 0) {
           return null;
         }
 }}}

 Which is called from `XPIProvider::installDistributionAddons`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33672#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list