[tor-bugs] #33674 [Core Tor/Tor]: Check return value handling in the relay and dirauth stubs

[Tor Bug Tracker & Wiki]

#33674: Check return value handling in the relay and dirauth stubs
--------------------------------------+------------------------------------
 Reporter:  teor                      |          Owner:  teor
     Type:  task                      |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  043-must, technical-debt  |  Actual Points:  0.3
Parent ID:                            |         Points:  0.5
 Reviewer:  nickm                     |        Sponsor:
--------------------------------------+------------------------------------
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 Actually, it looks like there is a non-spurious CI warning on the master
 version:
 {{{
 ./src/feature/relay/routerkeys.h:92:36: error: parameter ‘sign_out’ set
 but not used [-Werror=unused-but-set-parameter]
                                int *sign_out)
                                     ^~~~~~~~
 ./src/feature/relay/routerkeys.h: In function
 ‘make_tap_onion_key_crosscert’:
 ./src/feature/relay/routerkeys.h:106:35: error: parameter ‘len_out’ set
 but not used [-Werror=unused-but-set-parameter]
                               int *len_out)
                                    ^~~~~~~
 }}}

 (The 0.4.3 branch is already merged)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33674#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online