[tor-bugs] #21952 [Applications/Tor Browser]: Onion-location: increasing the use of onion services through automatic redirects and aliasing

[Tor Bug Tracker & Wiki]

#21952: Onion-location: increasing the use of onion services through automatic
redirects and aliasing
-------------------------------------------------+-------------------------
 Reporter:  linda                                |          Owner:  acat
     Type:  project                              |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, tor-hs, network-team-       |  Actual Points:  10
  roadmap-november, tbb-9.5, network-team-       |
  roadmap-2020Q1, TorBrowserTeam202003R          |
Parent ID:  #30024                               |         Points:  6
 Reviewer:  pospeselr, mcs, brade                |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------

Comment (by acat):

 Replying to [comment:116 mcs]:

 > * UX: Now that clicking "Always Prioritize Onionsites" flips the pref
 for me, I expect that the redirect will be followed for that page without
 me doing more. Would it surprise people too much if we did that or would
 it be an improvement?

 Maybe we can ask for more opinions, but I thought this made sense and
 implemented it in the revision.

 > * Kathy and I expected that `privacy.prioritizeonions.showNotification`
 would default to `true` to indicate that the notification should be
 displayed. That is what I meant in comment:111 when I said "reverse the
 meaning."
 True, I missed this one. Thanks.

 ----

 Here is a revised patch for review: https://github.com/acatarineu/tor-
 browser/commit/21952+6. While working on it, I realized that the
 implementation could be buggy in some (not so common) cases. This is
 because the cleanup of the `OnionLocation` in `browser.js` was being done
 in the `XULBrowserWindow` `onStateChange` function, which fires only in
 the currently selected tab. That means that if a tab which had a
 `OnionLocation` UI changed to a different location while not selected, the
 `onionsite available` badge would not be removed. To fix it I moved the
 cleanup to the `onStateChange` function of the `TabsProgressListener`,
 which should also fire for tabs that are not currently selected.

 The `Add search engines` badge implementation in Firefox is also buggy in
 the same way, so I'll file a bugzilla ticket if it's not already there.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21952#comment:117>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online