[tor-bugs] #33633 [Core Tor/Tor]: Move extend and reachability code to the relay module

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Mar 18 15:14:43 UTC 2020


#33633: Move extend and reachability code to the relay module
-------------------------------------------+-------------------------------
 Reporter:  teor                           |          Owner:  teor
     Type:  task                           |         Status:  needs_review
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.4.4.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  ipv6, prop311, technical-debt  |  Actual Points:  0.5
Parent ID:  #33220                         |         Points:  0.5
 Reviewer:  nickm                          |        Sponsor:
                                           |  Sponsor55-must
-------------------------------------------+-------------------------------

Comment (by nickm):

 Looks good on first glance. I need to take a second look at these commits,
 since they are nontrivial.
   * relay: Split link specifier checks from circuit_extend()
   * relay: Split out opening a connection for an extend

 In the mean time, is it reasonable to try to get test coverage here,
 particularly on the new check functions introduced in those two commits?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33633#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list