[tor-bugs] #33428 [Core Tor/Chutney]: Make chutney check for relay microdescriptors before verifying

[Tor Bug Tracker & Wiki]

#33428: Make chutney check for relay microdescriptors before verifying
-------------------------------------------+-------------------------------
 Reporter:  teor                           |          Owner:  (none)
     Type:  enhancement                    |         Status:  new
 Priority:  Medium                         |      Milestone:
Component:  Core Tor/Chutney               |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  ipv6, prop311, outreachy-ipv6  |  Actual Points:
Parent ID:  #33050                         |         Points:  1
 Reviewer:                                 |        Sponsor:  Sponsor55-can
-------------------------------------------+-------------------------------

Comment (by teor):

 Replying to [comment:13 anuradha1904]:
 > Replying to [comment:6 teor]: Hey teor, all thanks to you, I am done
 with majority of the task of the function, can you please guide me "set
 ed25519-id in the Environ to that value" step. Thank you.

 Hi, I'd like to look at the code you've written so far. Lots of developers
 get reviews on incomplete code, particularly when they are working on a
 new project.

 Please submit a pull request (PR) on the chutney GitHub, containing the
 code you have written so far:
 https://github.com/torproject/chutney

 When you submit your PR, GitHub will run chutney's continuous integration
 (CI). Let us know if CI fails, and we will help you fix it.

 (Sometimes CI fails because of the server or other programs, not your
 code.)

 > > Replying to [comment:5 anuradha1904]:
 > > You can start by writing a function called _setEd25519Id(), which
 should be called at the end of _genRouterKey():
 > >
 https://github.com/torproject/chutney/blob/master/lib/chutney/TorNet.py#L741
 > >
 > > The function should:
 > > * read keys/ed25519_master_id_public_key from datadir, if that file
 exists
 > > * extract the key data
 > > * convert it to base64
 > > * discard the trailing "="

 Your PR should do these things.

 > > * set `ed25519-id` in the Environ to that value

 You can set ed25519-id in a similar way to the code in _genRouterKey(),
 which sets fingerprint:
 {{{
 self._env['fingerprint'] = fingerprint
 }}}

 https://github.com/torproject/chutney/blob/9ffa2857fb4c6e75156159233263ac5898fc410c/lib/chutney/TorNet.py#L744

 > > You can check you have the right value, by printing it out, then
 searching for it in the cached-microdescs and cached-microdescs.new files
 in the datadir.

 Did you do this check?

 > > After you've written _setEd25519Id(), we can move on to the rest of
 this task.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33428#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online