[tor-bugs] #33361 [Core Tor/Tor]: relay: Warn about the lack of ContactInfo and the consequence

[Tor Bug Tracker & Wiki]

#33361: relay: Warn about the lack of ContactInfo and the consequence
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-backport, 041-backport,          |  Actual Points:
  042-backport, 043-backport, consider-          |
  backport-after-0433, network-health            |
Parent ID:                                       |         Points:  0.1
 Reviewer:  gk                                   |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  merge_ready => needs_revision


Comment:

 Replying to [comment:10 nickm]:
 > I've added another commit to the branch , to make the unit tests pass.
 I'm testing it on 0.4.3, and if it passes, I'll merge it to 0.4.3 and
 forward.
 >
 > (Please remember to check CI, folks!)

 Okay, it seems I can't see any CI reports without logging in to Github, so
 I missed that and I forgot to run `make test`, locally to have at least
 some more indicators whether things are okay or not. Doing that for the
 not yet merged 0.3.5 patch indicates actually two test failures instead of
 one for 0.4.3:
 {{{
 options/validate__uname_for_server: [forking]
   FAIL ../src/test/test_options.c:518: expected log to not contain entries
 Captured logs:
     1. warn: "Your ContactInfo config option is not set. Please strongly
 consider setting it, so we can contact you if your relay is misconfigured,
 end-of-life, or something else goes wrong. It is also possible that your
 relay might get rejected from the network due to a missing valid contact
 address.\n"

   [validate__uname_for_server FAILED]
 options/validate__outbound_addresses: [forking] OK
 options/validate__data_directory: [forking] OK
 options/validate__nickname: [forking] OK
 options/validate__contactinfo: [forking]
   FAIL ../src/test/test_options.c:635: expected log to contain "Your
 ContactInfo config option is not set. Please consider setting it, so we
 can contact you if your server is misconfigured or something else goes
 wrong.
 }}}
 Not sure what the network-team policy is for such a case like this but I
 am marking this ticket as `needs_revision` so we get a branch that
 properly applies to 0.3.5.x.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33361#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online