[tor-bugs] #32143 [Core Tor/Tor]: Build some CI jobs with ALL_BUGS_ARE_FATAL

[Tor Bug Tracker & Wiki]

#32143: Build some CI jobs with ALL_BUGS_ARE_FATAL
-------------------------------+------------------------------------
 Reporter:  teor               |          Owner:  (none)
     Type:  task               |         Status:  needs_revision
 Priority:  Medium             |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor       |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  043-should tor-ci  |  Actual Points:
Parent ID:                     |         Points:  0.2
 Reviewer:  teor               |        Sponsor:
-------------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:7 nickm]:
 > I've added a comment about the way that we're invoking `configure` here,
 and one about CFLAGS is handled.
 >
 > Additionally, I'd like to request additional review from Teor if
 possible, on the question of CI speed.  Teor has done good work recently
 on CI performance, and I'd like their opinion on:
 >    * whether this will slow down CI much,
 >    * whether there is any sensible workaround for that,
 >    * and whether we should try to apply the workaround before or after
 merge.

 Thanks Nick!

 I'd like to avoid adding any extra jobs, if possible. Instead, we could:
 * try to build all existing jobs with ALL_BUGS_ARE_FATAL, unless there's
 some reason we want to turn hardening options off (coverage, distcheck)
 * make ALL_BUGS_ARE_FATAL apply to Appveyor, as well as Travis

 If that causes too many CI failures, we could:
 * add a few jobs on Travis. I recommended a list of jobs we could add,
 without adding too much extra time. (Due to Travis parallelism.)
 * stop using ALL_BUGS_ARE_FATAL on Appveyor.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32143#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online