[tor-bugs] #32994 [Core Tor/Tor]: Get all flag defaults from port_cfg_new()

[Tor Bug Tracker & Wiki]

#32994: Get all flag defaults from port_cfg_new()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  MrSquanchee
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review, technical-debt, tor-   |  Actual Points:  0.2
  client, easy, intro, outreachy-ipv6            |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * reviewer:  teor =>


Comment:

 Replying to [comment:15 MrSquanchee]:
 > I made the changes requested. Travic CI and Appveyor checks are greened.
 > Needs a fresh review :)
 >
 > Additional suggestions and changes are most welcomed.
 >
 > @https://github.com/torproject/tor/pull/1795

 I think there's a simpler way to free cfg at the end of the function.

 What do you think of:
 https://github.com/torproject/tor/pull/1796/commits/3b7b512908e65ad74e672ea846151f31a0b31c97

 (This function is a bit confusing, because it's very big. Over time, we
 want to split big functions into smaller functions, so they are easier to
 understand. But we don't need to do that in this pull request.)

 If you like my change, then we are almost done!

 The final step is to make a changes file:
 https://gitweb.torproject.org/tor.git/tree/doc/HACKING/CodingStandards.md#n95

 I like to copy an existing changes file, and use it as a template.
 Remember to change the ticket number!

 You can also say "Patch by MrSquanchee" at the end of the changes file, if
 you like.

 Here is a good example of a "Code simplification and refactoring" changes
 file:
 https://github.com/torproject/tor/blob/master/changes/ticket33349

 Run "make check-changes" after you're done, to check the format of the
 file.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32994#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online