[tor-bugs] #32994 [Core Tor/Tor]: Get all flag defaults from port_cfg_new()

[Tor Bug Tracker & Wiki]

#32994: Get all flag defaults from port_cfg_new()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:
                                                 |  MrSquanchee
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  technical-debt, tor-client, easy,    |  Actual Points:
  intro, outreachy-ipv6                          |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:8 nickm]:
 > A good solution here might be to create the port_cfg_t object near the
 start of the loop in port_cfg_t, and then assign to its flags directly,
 rather than first assigning them to intermediate variables and only
 copying them at the end of the loop.  Teor might have some thoughts here
 as the original opener of this bug.

 Yes, I think we should create a `port_config_t` object using
 `port_config_new()` at the start of:
 * `port_parse_config()`
 * `connection_listener_new()`
 And then make any changes we need to make in that object.

 Please let us know if you find any differences between the default flags
 in `port_config_new()` and `port_parse_config()`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32994#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online