[tor-bugs] #33573 [Core Tor/Tor]: Update dir-spec descriptor cosmetic difference criteria (12 hours -> 2 hours)

[Tor Bug Tracker & Wiki]

#33573: Update dir-spec descriptor cosmetic difference criteria (12 hours -> 2
hours)
--------------------+------------------------------
 Reporter:  opara   |          Owner:  (none)
     Type:  defect  |         Status:  new
 Priority:  Medium  |      Component:  Core Tor/Tor
  Version:          |       Severity:  Normal
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
 Reviewer:          |        Sponsor:
--------------------+------------------------------
 In section 3.2 of the dir-spec document it says:

 {{{
 If the authority _does_ have a descriptor with the same public key, the
 newly uploaded descriptor is remembered if its publication time is more
 recent than the most recent old descriptor for that router, and either:

    - There are non-cosmetic differences between the old descriptor and the
      new one.
    - Enough time has passed between the descriptors' publication times.
      (Currently, 12 hours.)
 }}}

 This value of 12 hours was change in
 [https://gitweb.torproject.org/tor.git/commit/?id=cc3515780529277a5f9d788e8a256798e5cd144f
 commit cc351578] to 2 hours.

 In addition,
 [https://gitweb.torproject.org/tor.git/tree/src/feature/nodelist/routerlist.c?id=8096f3b2549971e120fa3869ea9e458fdad313d5#n2925
 a comment] in the tor code still says 12 hours.

 This ticket covers two changes:
  - update the dir-spec to say 2 hours
  - update a comment in the tor code

 Will attach two PRs shortly.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33573>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online