[tor-bugs] #33533 [Applications/Tor Browser]: Rebase Tor Browser esr68 patches on top of mozilla-central

[Tor Bug Tracker & Wiki]

#33533: Rebase Tor Browser esr68 patches on top of mozilla-central
--------------------------------------+------------------------------
 Reporter:  acat                      |          Owner:  acat
     Type:  task                      |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam202003R     |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------

Comment (by acat):

 I tried building with https://github.com/acatarineu/tor-browser-
 build/commit/33533, but there's an error in the Firefox project:

 {{{
 35:06.18     Finished release [optimized] target(s) in 34m 23s
 35:09.04 /var/tmp/build/firefox-07a065df4cae/obj-x86_64-pc-linux-
 gnu/_virtualenvs/init/bin/python -m mozbuild.action.check_binary --target
 --networking /var/tmp/build/firefox-07a065df4cae/obj-x86_64-pc-linux-gnu/
 x86_64-unknown-linux-gnu/release/libgkrust.a
 35:09.30 Traceback (most recent call last):
 35:09.30   File "/usr/lib/python2.7/runpy.py", line 162, in
 _run_module_as_main
 35:09.30     "__main__", fname, loader, pkg_name)
 35:09.30   File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
 35:09.30     exec code in run_globals
 35:09.30   File "/var/tmp/build/firefox-
 07a065df4cae/python/mozbuild/mozbuild/action/check_binary.py", line 359,
 in <module>
 35:09.30     sys.exit(main(sys.argv[1:]))
 35:09.30   File "/var/tmp/build/firefox-
 07a065df4cae/python/mozbuild/mozbuild/action/check_binary.py", line 351,
 in main
 35:09.30     return check_networking(options.binary)
 35:09.30   File "/var/tmp/build/firefox-
 07a065df4cae/python/mozbuild/mozbuild/action/check_binary.py", line 270,
 in check_networking
 35:09.30     for sym in at_least_one(iter_symbols(binary)):
 35:09.30   File "/var/tmp/build/firefox-
 07a065df4cae/python/mozbuild/mozbuild/action/check_binary.py", line 72, in
 at_least_one
 35:09.30     for item in iter:
 35:09.30   File "/var/tmp/build/firefox-
 07a065df4cae/python/mozbuild/mozbuild/action/check_binary.py", line 82, in
 iter_symbols
 35:09.30     ty = get_type(binary)
 35:09.30   File "/var/tmp/build/firefox-
 07a065df4cae/python/mozbuild/mozbuild/util.py", line 1007, in __call__
 35:09.30     self[args] = self.func(*args)
 35:09.30   File "/var/tmp/build/firefox-
 07a065df4cae/python/mozbuild/mozpack/executables.py", line 37, in get_type
 35:09.30     signature = struct.unpack('>L', signature)[0]
 35:09.30 TypeError: Struct() argument 1 must be string, not unicode
 35:09.32 make[4]: *** [/var/tmp/build/firefox-07a065df4cae/obj-x86_64-pc-
 linux-gnu/x86_64-unknown-linux-gnu/release/libgkrust.a] Error 1
 35:09.32 make[4]: *** Deleting file `/var/tmp/build/firefox-07a065df4cae
 /obj-x86_64-pc-linux-gnu/x86_64-unknown-linux-gnu/release/libgkrust.a'
 35:09.32 make[4]: Leaving directory `/var/tmp/build/firefox-07a065df4cae
 /obj-x86_64-pc-linux-gnu/toolkit/library/rust'
 35:09.32 make[3]: *** [toolkit/library/rust/target] Error 2
 35:09.32 make[3]: *** Waiting for unfinished jobs....
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33533#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online