[tor-bugs] #30992 [Core Tor/Tor]: circpadding machines have shutdown sync issues (with intro circ NACKs and other cases)

[Tor Bug Tracker & Wiki]

#30992: circpadding machines have shutdown sync issues (with intro circ NACKs and
other cases)
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
                                                 |  mikeperry
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.1.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad circpad-researchers-maybe-   |  Actual Points:
  want 043-should                                |
Parent ID:                                       |         Points:  3
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * status:  needs_revision => needs_review


Comment:

 Ok I pushed fixups for your comments and made a squashed PR for just this
 bug here: https://github.com/torproject/tor/pull/1925

 I am going to break #32040 off because I think we should clean up the
 apply vs keep flags for both intro and rend, but the unit tests disagree.
 So we should do a little more work on that one before merge.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30992#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online